Re: [PATCH v2 net-next] net: rnpgbe: Delete a null pointer check in rnpgbe_rm_adapter()

[Andrew Lunn]

On Thu, Jul 16, 2026 at 07:26:21PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Thu, 16 Jul 2026 19:15:06 +0200
> 
> The check for the pointer “mucse” was finally identified as undesirable.

I'm not sure finally is appropriate. It was one of the first questions
i asked. Also, i expect anybody looking at a Coccinelle report to take
the time to understand the code and decide what the correct fix is. We
have too many developers doing the minimum to make the tool happy,
without actually thinking.

Please also include the reasoning behind this. The commit message is
all about "Why?" Why is it undesirable?

And lastly, please always start a new thread for a new version of the
patch.

    Andrew

---
pw-bot: cr