Re: [PATCH net 2/7] selftests: openvswitch: add config file

[Aaron Conole]

Aaron Conole <aconole@xxxxxxxxxx> writes:

> Hi Matthieu,
>
> "Matthieu Baerts (NGI0)" <matttbe@xxxxxxxxxx> writes:
>
>> The kselftests doc mentions that a config file should be present "if a
>> test needs specific kernel config options enabled". This selftest
>> requires some kernel config, but no config file was provided.
>>
>> We could say that a sub-target could use the parent's config file, but
>> the kselftests doc doesn't mention anything about that. Plus the
>> net/openvswitch target is the only net target without a config file.
>
> We've been operating on that assumption from the openvswitch side, but
> it's true that isn't explicitly documented anywhere, and I guess it
> isn't officially supported in the kselftest framework.  I guess we'll
> need to keep updating this config as we add tests for things like SCTP,
> and others, and maybe that's a good thing like we can add a comment
> describing which tests take which configs.
>
> The downside is for most of the OVS testing we use the NIPA scripts
> and those 'inherit' the parent config, so it would be a change on our
> side from the development standpoint (but probably something we should
> have been doing from the beginning).
>
> That said, would it be worth also exploring the 'cascading
> configuration' support?  It seems like a useful feature, but maybe it
> should be a separate discussion.  I ask because of how OVS interacts
> with the networking stack as an 'alternative bridge' so-to-speak, I do
> worry about having to duplicate lots of configurations between the two
> as we expand the test coverage on OVS side.
>
>> Here is a new config file, which is a trimmed version of the net one,
>> with hopefully the minimal required kconfig on top of 'make defconfig'.
>
> Should this also remove the OVS configs from the upper level since there
> shouldn't be OVS tests executing there (ie: CONFIG_OPENVSWITCH*)?

Actually, forget this part.  The P-MTU tests in pmtu.sh use ovs to
create a datapath through OVS.  So these configurations need to stay at
the top level as well.

>> The Fixes tag points to the introduction of the net/openvswitch target,
>> just to help validating this target on stable kernels.
>>
>> Fixes: 25f16c873fb1 ("selftests: add openvswitch selftest suite")
>> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@xxxxxxxxxx>
>> ---
>> To: Aaron Conole <aconole@xxxxxxxxxx>
>> To: Eelco Chaudron <echaudro@xxxxxxxxxx>
>> To: Ilya Maximets <i.maximets@xxxxxxx>
>> Cc: dev@xxxxxxxxxxxxxxx
>> ---
>>  tools/testing/selftests/net/openvswitch/config | 16 ++++++++++++++++
>>  1 file changed, 16 insertions(+)
>>
>> diff --git a/tools/testing/selftests/net/openvswitch/config
>> b/tools/testing/selftests/net/openvswitch/config
>> new file mode 100644
>> index 000000000000..c659749cd086
>> --- /dev/null
>> +++ b/tools/testing/selftests/net/openvswitch/config
>> @@ -0,0 +1,16 @@
>> +CONFIG_GENEVE=m
>> +CONFIG_INET_DIAG=y
>> +CONFIG_IPV6=y
>> +CONFIG_NETFILTER=y
>> +CONFIG_NET_IPGRE=m
>> +CONFIG_NET_IPGRE_DEMUX=m
>> +CONFIG_NF_CONNTRACK=m
>> +CONFIG_NF_CONNTRACK_OVS=y
>> +CONFIG_OPENVSWITCH=m
>> +CONFIG_OPENVSWITCH_GENEVE=m
>> +CONFIG_OPENVSWITCH_GRE=m
>> +CONFIG_OPENVSWITCH_VXLAN=m
>> +CONFIG_PSAMPLE=m
>> +CONFIG_VETH=y
>> +CONFIG_VLAN_8021Q=y
>> +CONFIG_VXLAN=m