Re: [PATCH v1 2/3] perf jevents: Add python type annotations

[Ian Rogers]

On Thu, Jul 16, 2026 at 11:23 AM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
>
> On Thu, Jul 16, 2026 at 10:25:01AM -0700, Ian Rogers wrote:
> > On Thu, Jul 16, 2026 at 9:56 AM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
> > >
> > > On Mon, Jul 06, 2026 at 08:40:18PM -0700, Ian Rogers wrote:
> > > > Make mypy clean.
> > > >
> > > > Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
> > > > ---
> > > >  tools/perf/pmu-events/jevents.py | 77 +++++++++++++++++++-------------
> > > >  1 file changed, 45 insertions(+), 32 deletions(-)
> > > >
> > > > diff --git a/tools/perf/pmu-events/jevents.py b/tools/perf/pmu-events/jevents.py
> > > > index 3c6cfeefbd5d..83a239dd69f5 100755
> > > > --- a/tools/perf/pmu-events/jevents.py
> > > > +++ b/tools/perf/pmu-events/jevents.py
> > > > @@ -14,27 +14,27 @@ import collections
> > > >  # Global command line arguments.
> > > >  _args = None
> > > >  # List of regular event tables.
> > > > -_event_tables = []
> > > > +_event_tables: list[str] = []
> > >
> > > I got this from one of my test setup.
> > >
> > >     GEN     /build/pmu-events/test-empty-pmu-events.c
> > >   Traceback (most recent call last):
> > >     File "pmu-events/jevents.py", line 17, in <module>
> > >       _event_tables: list[str] = []
> > >   TypeError: 'type' object is not subscriptable
> > >   make[3]: *** [pmu-events/Build:176: /build/pmu-events/test-empty-pmu-events.c] Error 1
> > >   make[2]: *** [Makefile.perf:550: /build/pmu-events/pmu-events-in.o] Error 2
> > >   make[2]: *** Waiting for unfinished jobs....
> > >   make[1]: *** [Makefile.perf:288: sub-make] Error 2
> > >   make: *** [Makefile:76: all] Error 2
> > >
> > > Python version was 3.6.15.
> >
> > I believe the minimum Python version should be 3.9.x:
> > https://docs.kernel.org/process/changes.html
> > That version will resolve this issue.
>
> Hmm.. ok.  I'll re-add them then.

Thanks! Fwiw, Sashiko should also keep us honest here by checking the
minimum tool version as we instruct it to read that from the
documentation:
https://github.com/masoncl/review-prompts/blob/main/kernel/subsystem/build.md

Thanks,
Ian

> Thanks,
> Namhyung
>