Re: [PATCH v2 2/2] media: synopsys: hdmirx: add HDMI audio capture support
From: Dmitry Osipenko
Date: Thu Jul 16 2026 - 19:09:06 EST
15.07.2026 23:08, Igor Paunovic пишет:
> @@ -2788,6 +3058,16 @@ static void hdmirx_remove(struct platform_device *pdev)
> struct device *dev = &pdev->dev;
> struct snps_hdmirx_dev *hdmirx_dev = dev_get_drvdata(dev);
>
> + /*
> + * Clear the streaming flag first so a running worker cannot re-arm
> + * itself, then tear down the codec (which stops any active stream)
> + * before the final cancel.
> + */
> + WRITE_ONCE(hdmirx_dev->audio_streaming, false);
> + if (hdmirx_dev->audio_pdev)
> + platform_device_unregister(hdmirx_dev->audio_pdev);
> + cancel_delayed_work_sync(&hdmirx_dev->audio_work);
> +
Audio capture should be stopped when the codec removed and
hdmirx_audio_shutdown() stops the audio_work. The v1 was good here,
Sashiko bot should be wrong.
I'd like to see rest of the patches (I2S and etc) to test this patch
before giving ack.
--
Best regards,
Dmitry