RE: [PATCH v2 4/4] HID: Intel-thc-hid: Remove redundant dev_err()

[Xu, Even]

> -----Original Message-----
> From: Pan Chuang <panchuang@xxxxxxxx>
> Sent: Thursday, July 16, 2026 3:52 PM
> To: Xu, Even <even.xu@xxxxxxxxx>; Sun, Xinpeng <xinpeng.sun@xxxxxxxxx>; Jiri
> Kosina <jikos@xxxxxxxxxx>; Benjamin Tissoires <bentiss@xxxxxxxxxx>; Sakari Ailus
> <sakari.ailus@xxxxxxxxxxxxxxx>; Pan Chuang <panchuang@xxxxxxxx>; Abhishek
> Tamboli <abhishektamboli9@xxxxxxxxx>; Danny D. <d3z.the.dev@xxxxxxxxx>;
> open list:HID CORE LAYER <linux-input@xxxxxxxxxxxxxxx>; open list <linux-
> kernel@xxxxxxxxxxxxxxx>
> Subject: [PATCH v2 4/4] HID: Intel-thc-hid: Remove redundant dev_err()
> 
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant driver-specific
> dev_err() calls.
> 
> Signed-off-by: Pan Chuang <panchuang@xxxxxxxx>
> ---
>  drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c | 5 +----  drivers/hid/intel-
> thc-hid/intel-quickspi/pci-quickspi.c | 5 +----
>  2 files changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c
> b/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c
> index 46d3e9a01999..59f500345acb 100644
> --- a/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c
> +++ b/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c
> @@ -682,11 +682,8 @@ static int quicki2c_probe(struct pci_dev *pdev, const
> struct pci_device_id *id)
>  					quicki2c_irq_thread_handler,
>  					IRQF_ONESHOT, KBUILD_MODNAME,
>  					qcdev);
> -	if (ret) {
> -		dev_err_once(&pdev->dev,
> -			     "Failed to request threaded IRQ, irq = %d.\n", pdev-
> >irq);
> +	if (ret)
>  		goto dev_deinit;
> -	}
> 
>  	ret = quicki2c_get_device_descriptor(qcdev);
>  	if (ret) {
> diff --git a/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
> b/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
> index 4ae2e1718b30..504ef3c842ab 100644
> --- a/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
> +++ b/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
> @@ -636,11 +636,8 @@ static int quickspi_probe(struct pci_dev *pdev,
>  					quickspi_irq_thread_handler,
>  					IRQF_ONESHOT, KBUILD_MODNAME,
>  					qsdev);
> -	if (ret) {
> -		dev_err(&pdev->dev,
> -			"Failed to request threaded IRQ, irq = %d.\n", pdev-
> >irq);
> +	if (ret)
>  		goto dev_deinit;
> -	}

Thank you for the patches!

Reviewed-by: Even Xu <even.xu@xxxxxxxxx>

> 
>  	ret = reset_tic(qsdev);
>  	if (ret) {
> --
> 2.34.1