Re: [PATCH v2 06/10] media: microchip-isc: store the unshifted PFE_CFG0 BPS value

[Eugen Hristev]

On 6/29/26 14:09, Balakrishnan Sambath wrote:
> pfe_cfg0_bps held a pre-shifted BPS value (ISC_PFE_CFG0_BPS_EIGHT was
> 0x4 << 28) ORed straight into the register. The other format selectors
> like cfa_baycfg store the bare field value and position it at the write,
> so this one was inconsistent.
> 
> Store the bare BPS value and apply it with FIELD_PREP() at the PFE_CFG0
> write, and fix the pfe_cfg0_bps comment to match. No functional change.
> 
> Suggested-by: Eugen Hristev <ehristev@xxxxxxxxxx>
> Signed-off-by: Balakrishnan Sambath <balakrishnan.s@xxxxxxxxxxxxx>
> ---
>  drivers/media/platform/microchip/microchip-isc-base.c |  4 +++-
>  drivers/media/platform/microchip/microchip-isc-regs.h | 10 +++++-----
>  drivers/media/platform/microchip/microchip-isc.h      |  4 +++-
>  3 files changed, 11 insertions(+), 7 deletions(-)
> 

Reviewed-by: Eugen Hristev <ehristev@xxxxxxxxxx>