RE: [External Mail] Re: [PATCH v4 2/7] net: wwan: t9xx: Add control plane transaction layer

[Wu. JackBB (GSM)]

Hi Simon,

> > +int mtk_ctrl_init(struct mtk_md_dev *mdev)
> > +{
> > +	struct mtk_ctrl_blk *ctrl_blk;
> > +	ctrl_blk = devm_kzalloc(mdev->dev, sizeof(*ctrl_blk), GFP_KERNEL);
>
> [Severity: Medium]
> Does this patch actually implement the TX and RX services described
> in the commit message?

We will rewrite the commit message to accurately describe
what this patch does — it introduces the control plane framework
and data structures, not the TX/RX service implementations.

> > +	return LE32_TO_U32(cpu_to_le32(hw_bits));
> > +}
>
> [Severity: High]
> Does this code apply a double byte-swap on big-endian architectures?

T9XX currently only targets x86 (little-endian) platforms where
cpu_to_le32() is a no-op. The Kconfig enforces "depends on PCI &&
ACPI" which restricts this to x86 platforms. On little-endian, no
byte-swap occurs at any point, so ffs() operates on the correct
value.

Thanks.

Jack Wu