[PATCH 03/12] crypto: aspeed - Remove redundant dev_err()

From: Pan Chuang

Date: Fri Jul 17 2026 - 04:02:50 EST


Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.

Signed-off-by: Pan Chuang <panchuang@xxxxxxxx>
---
drivers/crypto/aspeed/aspeed-acry.c | 4 +---
drivers/crypto/aspeed/aspeed-hace.c | 4 +---
2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/crypto/aspeed/aspeed-acry.c b/drivers/crypto/aspeed/aspeed-acry.c
index 5993bcba9716..8d13f01e7a37 100644
--- a/drivers/crypto/aspeed/aspeed-acry.c
+++ b/drivers/crypto/aspeed/aspeed-acry.c
@@ -732,10 +732,8 @@ static int aspeed_acry_probe(struct platform_device *pdev)

rc = devm_request_irq(dev, acry_dev->irq, aspeed_acry_irq, 0,
dev_name(dev), acry_dev);
- if (rc) {
- dev_err(dev, "Failed to request irq.\n");
+ if (rc)
return rc;
- }

acry_dev->clk = devm_clk_get_enabled(dev, NULL);
if (IS_ERR(acry_dev->clk)) {
diff --git a/drivers/crypto/aspeed/aspeed-hace.c b/drivers/crypto/aspeed/aspeed-hace.c
index 3fe644bfe037..6677cba666d7 100644
--- a/drivers/crypto/aspeed/aspeed-hace.c
+++ b/drivers/crypto/aspeed/aspeed-hace.c
@@ -131,10 +131,8 @@ static int aspeed_hace_probe(struct platform_device *pdev)

rc = devm_request_irq(&pdev->dev, hace_dev->irq, aspeed_hace_irq, 0,
dev_name(&pdev->dev), hace_dev);
- if (rc) {
- dev_err(&pdev->dev, "Failed to request interrupt\n");
+ if (rc)
return rc;
- }

/* Get clk and enable it */
hace_dev->clk = devm_clk_get(&pdev->dev, NULL);
--
2.34.1