Re: [PATCHv2] crypto: cesa: switch to non-devm IRQ to free it earlier

[Herbert Xu]

On Sun, Jul 12, 2026 at 08:15:32PM -0700, Rosen Penev wrote:
> Switch the IRQ request from devm_request_threaded_irq() to
> request_threaded_irq() so the IRQ is released explicitly, allowing it to
> be freed earlier in the cleanup path rather than deferred to device
> teardown.
> 
> Add the matching free_irq() and irq_set_affinity_hint(NULL) calls in both
> the probe error path and the remove function to release the IRQ and clear
> the affinity hint set during probe.
> 
> Fixes: f63601fd616ab ("crypto: marvell/cesa - add a new driver for Marvell's CESA")
> Assisted-by: opencode:big-pickle
> Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
> ---
>  v2: fixed Fixes tag and reworded commit
>  drivers/crypto/marvell/cesa/cesa.c | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)

This makes the code more complicated.  You need to explain why this
is desirable and the explanation needs to go into the patch description.

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt