Re: [PATCH v3 1/4] ASoC: dt-bindings: qcom: add LPASS LPR vote clock ID

[Krzysztof Kozlowski]

On Thu, Jul 16, 2026 at 08:16:33PM +0530, Prasad Kumpatla wrote:
> > >   #define LPASS_HW_DCODEC_VOTE		103
> > > +#define LPASS_HW_LPR_VOTE		104
> > > -#define Q6AFE_MAX_CLK_ID			104
> > > +#define Q6AFE_MAX_CLK_ID			105
> > Nope, ABI break. You cannot change that and as stated many times already
> > - if you need it, then it is not a binding.
> 
> Hi Krzysztof,
> 
> Thanks for the review.
> 
> LPASS_HW_LPR_VOTE is intended to be consumed via the DT clock
> specifier, similar to LPASS_HW_MACRO_VOTE and LPASS_HW_DCODEC_VOTE.
> My intention was therefore to add a new DT-visible clock ID.
> 
> Regarding the ABI concern, would assigning LPASS_HW_LPR_VOTE from
> the currently unused range (for example 100) and keeping
> Q6AFE_MAX_CLK_ID unchanged address the issue, or is the concern
> that LPASS_HW_LPR_VOTE should not be exposed as a DT binding at all?
> If not, could you please advise the appropriate place/example for
> defining this CLK ID?

Just drop the Q6AFE_MAX_CLK_ID from the bindings. I do not see it even
being used in the drivers, so no need to move it (unless you are aware
of some out-of-tree user).

Best regards,
Krzysztof