Re: [PATCH] mm/folio-compat: Drop superfluous return statements in void compat wrappers

From: David Hildenbrand (Arm)

Date: Fri Jul 17 2026 - 04:56:54 EST


On 7/17/26 10:42, Lorenzo Stoakes (ARM) wrote:
> On Fri, Jul 17, 2026 at 03:20:54PM +0800, Hongfu Li wrote:
>> From: Hongfu Li <lihongfu@xxxxxxxxxx>
>>
>> unlock_page(), end_page_writeback() and wait_on_page_writeback()
>> are void wrappers forwarding to folio-based functions which also
>> return void. Explicit return statements here are syntactically valid
>> but unnecessary, and inconsistent with other nearby compat helpers
>> such as mark_page_accessed() and set_page_writeback().
>>
>> Drop all these superfluous return keywords.
>>
>> Signed-off-by: Hongfu Li <lihongfu@xxxxxxxxxx>
>
> LGTM so:
>
> Reviewed-by: Lorenzo Stoakes (ARM) <ljs@xxxxxxxxxx>
>
> I would ask that you maybe slow down on the flow of patches lately :) review is
> pretty overwhelmed atm.

Exactly.

Acked-by: David Hildenbrand (Arm) <david@xxxxxxxxxx>

--
Cheers,

David