Re: [PATCH v2 1/4] HID: amd_sfh: Remove redundant dev_err()

[Basavaraj Natikar]

On 7/16/2026 1:21 PM, Pan Chuang wrote:
> [You don't often get email from panchuang@xxxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
> Signed-off-by: Pan Chuang <panchuang@xxxxxxxx>
> ---
>   drivers/hid/amd-sfh-hid/amd_sfh_pcie.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
> index 4b81cebdc335..a2acd3ca20e2 100644
> --- a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
> +++ b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
> @@ -128,11 +128,8 @@ int amd_sfh_irq_init_v2(struct amd_mp2_dev *privdata)
>
>          rc = devm_request_irq(&privdata->pdev->dev, privdata->pdev->irq,
>                                amd_sfh_irq_handler, 0, DRIVER_NAME, privdata);
> -       if (rc) {
> -               dev_err(&privdata->pdev->dev, "failed to request irq %d err=%d\n",
> -                       privdata->pdev->irq, rc);
> +       if (rc)
>                  return rc;
> -       }

Please change the function to return the call directly then

return devm_request_irq(&privdata->pdev->dev, privdata->pdev->irq,
			amd_sfh_irq_handler, 0, DRIVER_NAME, privdata);

With that change:

Acked-by: Basavaraj Natikar <Basavaraj.Natikar@xxxxxxx>

Thanks,
--
Basavaraj