[PATCH 1/3] misc: bcm-vk: Remove redundant dev_err()

From: Pan Chuang

Date: Fri Jul 17 2026 - 06:06:08 EST


Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.

Signed-off-by: Pan Chuang <panchuang@xxxxxxxx>
---
drivers/misc/bcm-vk/bcm_vk_dev.c | 15 +++------------
1 file changed, 3 insertions(+), 12 deletions(-)

diff --git a/drivers/misc/bcm-vk/bcm_vk_dev.c b/drivers/misc/bcm-vk/bcm_vk_dev.c
index 5773ffb46f0f..54b40b4d556d 100644
--- a/drivers/misc/bcm-vk/bcm_vk_dev.c
+++ b/drivers/misc/bcm-vk/bcm_vk_dev.c
@@ -1370,21 +1370,15 @@ static int bcm_vk_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
err = devm_request_irq(dev, pci_irq_vector(pdev, vk->num_irqs),
bcm_vk_msgq_irqhandler,
IRQF_SHARED, DRV_MODULE_NAME, vk);
- if (err) {
- dev_err(dev, "failed to request msgq IRQ %d for MSIX %d\n",
- pdev->irq + vk->num_irqs, vk->num_irqs + 1);
+ if (err)
goto err_irq;
- }
}
/* one irq for notification from VK */
err = devm_request_irq(dev, pci_irq_vector(pdev, vk->num_irqs),
bcm_vk_notf_irqhandler,
IRQF_SHARED, DRV_MODULE_NAME, vk);
- if (err) {
- dev_err(dev, "failed to request notf IRQ %d for MSIX %d\n",
- pdev->irq + vk->num_irqs, vk->num_irqs + 1);
+ if (err)
goto err_irq;
- }
vk->num_irqs++;

for (i = 0;
@@ -1393,11 +1387,8 @@ static int bcm_vk_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
err = devm_request_irq(dev, pci_irq_vector(pdev, vk->num_irqs),
bcm_vk_tty_irqhandler,
IRQF_SHARED, DRV_MODULE_NAME, vk);
- if (err) {
- dev_err(dev, "failed request tty IRQ %d for MSIX %d\n",
- pdev->irq + vk->num_irqs, vk->num_irqs + 1);
+ if (err)
goto err_irq;
- }
bcm_vk_tty_set_irq_enabled(vk, i);
}

--
2.34.1