Re: [PATCH v2 4/5] clk: qcom: gcc-hawi: Add support for global clock controller on Maili
From: Konrad Dybcio
Date: Fri Jul 17 2026 - 06:15:01 EST
On 7/13/26 11:04 AM, Taniya Das wrote:
> Add support for the global clock controller (GCC) on the Qualcomm Maili
> SoC by extending the Hawi global clock controller since Maili is identical
> to Hawi and has few additional clocks.
>
> Signed-off-by: Taniya Das <taniya.das@xxxxxxxxxxxxxxxx>
> ---
[...]
> + /*
> + * Maili-only clocks: NULL here to size the array to the highest Maili
> + * clock index.
> + */
> + [GCC_QUPV3_WRAP_5_S_AHB_CLK] = NULL,
This is unnecessary/wrong, as desc->num_clks validates the index in
qcom_cc_clk_hw_get().
Without this, we'd get an -EINVAL, with this we get a silent nullptr
Konrad