[PATCH 2/4] pinctrl: bcm: Remove redundant dev_err()
From: Pan Chuang
Date: Fri Jul 17 2026 - 07:02:59 EST
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@xxxxxxxx>
---
drivers/pinctrl/bcm/pinctrl-nsp-gpio.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c b/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c
index b425ecacd1b0..1fbb101386a3 100644
--- a/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c
+++ b/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c
@@ -671,11 +671,8 @@ static int nsp_gpio_probe(struct platform_device *pdev)
/* Install ISR for this GPIO controller. */
ret = devm_request_irq(dev, irq, nsp_gpio_irq_handler,
IRQF_SHARED, "gpio-a", &chip->gc);
- if (ret) {
- dev_err(&pdev->dev, "Unable to request IRQ%d: %d\n",
- irq, ret);
+ if (ret)
return ret;
- }
girq = &chip->gc.irq;
gpio_irq_chip_set_chip(girq, &nsp_gpio_irq_chip);
--
2.34.1