Re: [PATCH v2 0/3] MIPS: BCM47XX: convert buttons to software nodes
From: Thomas Bogendoerfer
Date: Fri Jul 17 2026 - 07:16:46 EST
On Mon, Jul 13, 2026 at 02:58:21PM -0700, Dmitry Torokhov wrote:
> This series converts the legacy gpio-keys platform device on BCM47XX
> boards to use software nodes and static properties.
>
> To do this properly without relying on legacy name-based matching
> (which is being removed from gpiolib), we introduce and register
> software nodes for the underlying GPIO controllers (BCMA and SSB)
> and reference them in the button properties.
>
> The first two patches add the software nodes to bcma-gpio and
> ssb-gpio respectively. The third patch performs the conversion
> for the BCM47XX buttons.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> ---
> As Johannes mentioned on v1 this best should go through MIPS tree.
>
> Changes in v2:
> - Restrict software node registration to host SoC devices in both ssb
> and bcma drivers to avoid conflicts when secondary buses (e.g. PCI
> wireless cards) are present
> - Fix dangling pointer panic in buttons driver by allocating software
> node references on the heap instead of stack
> - Link to v1: https://patch.msgid.link/20260704-b4-bcm47xx-swnode-v1-0-730d59340237@xxxxxxxxx
>
> ---
> Dmitry Torokhov (3):
> bcma: gpio: Add and register software node for GPIO controller
> ssb: gpio: Add and register software node for GPIO controller
> MIPS: BCM47XX: Convert buttons to software nodes
>
> arch/mips/bcm47xx/buttons.c | 442 +++++++++++++++++++++++++-------------------
series applied to mips-next
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]