Re: [PATCH 1/3] perf: Remove redundant dev_err()/dev_err_probe()

[Xu Yang]

On Fri, Jul 17, 2026 at 06:31:17PM +0800, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() and dev_err_probe() calls.
> 
> Signed-off-by: Pan Chuang <panchuang@xxxxxxxx>
> ---
>  drivers/perf/alibaba_uncore_drw_pmu.c | 5 +----
>  drivers/perf/fsl_imx8_ddr_perf.c      | 4 +---
>  drivers/perf/fsl_imx9_ddr_perf.c      | 4 +---
>  drivers/perf/fujitsu_uncore_pmu.c     | 2 +-
>  drivers/perf/qcom_l2_pmu.c            | 5 +----
>  drivers/perf/qcom_l3_pmu.c            | 5 +----
>  drivers/perf/starfive_starlink_pmu.c  | 2 +-
>  drivers/perf/xgene_pmu.c              | 4 +---
>  8 files changed, 8 insertions(+), 23 deletions(-)
> 
> diff --git a/drivers/perf/alibaba_uncore_drw_pmu.c b/drivers/perf/alibaba_uncore_drw_pmu.c
> index 74786a5dd6a2..fc934bccf4a6 100644
> --- a/drivers/perf/alibaba_uncore_drw_pmu.c
> +++ b/drivers/perf/alibaba_uncore_drw_pmu.c
> @@ -449,11 +449,8 @@ static struct ali_drw_pmu_irq *__ali_drw_pmu_init_irq(struct platform_device
>  	 */
>  	ret = devm_request_irq(&pdev->dev, irq_num, ali_drw_pmu_isr,
>  			       IRQF_SHARED, dev_name(&pdev->dev), irq);
> -	if (ret < 0) {
> -		dev_err(&pdev->dev,
> -			"Fail to request IRQ:%d ret:%d\n", irq_num, ret);
> +	if (ret < 0)
>  		goto out_free;
> -	}
>  
>  	ret = irq_set_affinity_hint(irq_num, cpumask_of(irq->cpu));
>  	if (ret)
> diff --git a/drivers/perf/fsl_imx8_ddr_perf.c b/drivers/perf/fsl_imx8_ddr_perf.c
> index 3760ebe02674..dd8046265584 100644
> --- a/drivers/perf/fsl_imx8_ddr_perf.c
> +++ b/drivers/perf/fsl_imx8_ddr_perf.c
> @@ -858,10 +858,8 @@ static int ddr_perf_probe(struct platform_device *pdev)
>  					IRQF_NOBALANCING | IRQF_NO_THREAD,
>  					DDR_CPUHP_CB_NAME,
>  					pmu);
> -	if (ret < 0) {
> -		dev_err(&pdev->dev, "Request irq failed: %d", ret);
> +	if (ret < 0)
>  		goto ddr_perf_err;
> -	}
>  
>  	pmu->irq = irq;
>  	ret = irq_set_affinity(pmu->irq, cpumask_of(pmu->cpu));
> diff --git a/drivers/perf/fsl_imx9_ddr_perf.c b/drivers/perf/fsl_imx9_ddr_perf.c
> index 6fee5eb5087a..d59bc5ea3155 100644
> --- a/drivers/perf/fsl_imx9_ddr_perf.c
> +++ b/drivers/perf/fsl_imx9_ddr_perf.c
> @@ -830,10 +830,8 @@ static int ddr_perf_probe(struct platform_device *pdev)
>  	ret = devm_request_irq(&pdev->dev, irq, ddr_perf_irq_handler,
>  			       IRQF_NOBALANCING | IRQF_NO_THREAD,
>  			       DDR_CPUHP_CB_NAME, pmu);
> -	if (ret < 0) {
> -		dev_err(&pdev->dev, "Request irq failed: %d", ret);
> +	if (ret < 0)
>  		goto ddr_perf_err;
> -	}
>  
>  	pmu->irq = irq;
>  	ret = irq_set_affinity(pmu->irq, cpumask_of(pmu->cpu));

Reviewed-by: Xu Yang <xu.yang_2@xxxxxxx>

Thanks,
Xu Yang