[PATCH 5/7] platform/mellanox: Remove redundant dev_err()
From: Pan Chuang
Date: Fri Jul 17 2026 - 07:25:17 EST
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@xxxxxxxx>
---
drivers/platform/mellanox/mlxbf-tmfifo.c | 1 -
drivers/platform/mellanox/mlxreg-hotplug.c | 4 +---
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/platform/mellanox/mlxbf-tmfifo.c b/drivers/platform/mellanox/mlxbf-tmfifo.c
index 3c6408581373..fb1d424659c6 100644
--- a/drivers/platform/mellanox/mlxbf-tmfifo.c
+++ b/drivers/platform/mellanox/mlxbf-tmfifo.c
@@ -1390,7 +1390,6 @@ static int mlxbf_tmfifo_probe(struct platform_device *pdev)
mlxbf_tmfifo_irq_handler, 0,
"tmfifo", &fifo->irq_info[i]);
if (rc) {
- dev_err(dev, "devm_request_irq failed\n");
fifo->irq_info[i].irq = 0;
return rc;
}
diff --git a/drivers/platform/mellanox/mlxreg-hotplug.c b/drivers/platform/mellanox/mlxreg-hotplug.c
index d246772aafd6..d6549dd21772 100644
--- a/drivers/platform/mellanox/mlxreg-hotplug.c
+++ b/drivers/platform/mellanox/mlxreg-hotplug.c
@@ -740,10 +740,8 @@ static int mlxreg_hotplug_probe(struct platform_device *pdev)
err = devm_request_irq(&pdev->dev, priv->irq,
mlxreg_hotplug_irq_handler, IRQF_TRIGGER_FALLING
| IRQF_SHARED, "mlxreg-hotplug", priv);
- if (err) {
- dev_err(&pdev->dev, "Failed to request irq: %d\n", err);
+ if (err)
return err;
- }
disable_irq(priv->irq);
spin_lock_init(&priv->lock);
--
2.34.1