Re: [PATCH v3 7/9] media: platform: broadcom: Move unicam driver to subdir

[Jai Luthra]

Quoting Jai Luthra (2026-07-17 16:34:22)
> The BCM283x/BCM2711x SoCs capture camera frames using CSI-2, and
> optionally process the raw frames using a VC4 firmware-based ISP block.
> 
> As the ISP driver will be added subsequently, move the files related to
> the unicam driver to a separate subdirectory to ease distinction between
> the two drivers' files.
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Signed-off-by: Jai Luthra <jai.luthra@xxxxxxxxxxxxxxxx>

[...]

> diff --git a/drivers/media/platform/broadcom/Kconfig b/drivers/media/platform/broadcom/Kconfig
> index 93ba565d9a02..cab44885182c 100644
> --- a/drivers/media/platform/broadcom/Kconfig
> +++ b/drivers/media/platform/broadcom/Kconfig
> @@ -1,18 +1,5 @@
>  # SPDX-License-Identifier: GPL-2.0
>  
> -config VIDEO_BCM2835_UNICAM
> -       tristate "Broadcom BCM283x/BCM271x Unicam video capture driver"
> -       depends on ARCH_BCM2835 || COMPILE_TEST
> -       depends on COMMON_CLK && PM
> -       depends on VIDEO_DEV
> -       select MEDIA_CONTROLLER
> -       select V4L2_FWNODE
> -       select VIDEO_V4L2_SUBDEV_API
> -       select VIDEOBUF2_DMA_CONTIG
> -       help
> -         Say Y here to enable support for the BCM283x/BCM271x CSI-2 receiver.
> -         This is a V4L2 driver that controls the CSI-2 receiver directly,
> -         independently from the VC4 firmware.
> +comment "Broadcom BCM283x/BCM271x media platform drivers"
>  
> -         To compile this driver as a module, choose M here. The module will be
> -         called bcm2835-unicam.
> +source "drivers/media/platform/broadcom/bcm2835-unicam/Kconfig"
> diff --git a/drivers/media/platform/broadcom/bcm2835-unicam/Kconfig b/drivers/media/platform/broadcom/bcm2835-unicam/Kconfig
> new file mode 100644
> index 000000000000..32b76ebfcd9a
> --- /dev/null
> +++ b/drivers/media/platform/broadcom/bcm2835-unicam/Kconfig
> @@ -0,0 +1,23 @@
> +# SPDX-License-Identifier: GPL-2.0
> +
> +config VIDEO_BCM2835_UNICAM
> +       tristate "Broadcom BCM283x/BCM271x Unicam video capture driver"
> +       depends on ARCH_BCM2835 || COMPILE_TEST
> +       depends on COMMON_CLK && PM
> +       depends on VIDEO_DEV
> +       select MEDIA_CONTROLLER
> +       select V4L2_FWNODE
> +       select VIDEO_V4L2_SUBDEV_API
> +       select VIDEOBUF2_DMA_CONTIG
> +       help
> +         Say Y here to enable support for the BCM283x/BCM271x CSI-2 receiver.
> +         This is a V4L2 driver that controls the CSI-2 receiver directly,
> +         independently from the VC4 firmware.
> +
> +         This driver is mutually exclusive with the use of bcm2835-camera. The
> +         firmware will disable all access to the peripheral from within the
> +         firmware if it finds a DT node using it, and bcm2835-camera will
> +         therefore fail to probe.
> +

Oops the above paragraph is no longer there in the old location, I must
have missed dropping it during the rebase.

> +         To compile this driver as a module, choose M here. The module will be
> +         called bcm2835-unicam.

--
Jai