Re: [PATCH v4] staging: rtl8723bs: remove redundant ReadChipVersion8723B wrapper

From: Greg KH

Date: Fri Jul 17 2026 - 08:17:10 EST


On Thu, Jul 16, 2026 at 05:33:10PM +0700, Arsenii Pashchenko wrote:
> Collapse the static CamelCase helper function ReadChipVersion8723B()
> directly into the main rtl8723b_read_chip_version() function.
> This removes unnecessary code nesting and cleans up the CamelCase
> naming violation in a single atomic change.
>
> ---
> Changes in v4:
> - Format patch via b4 as suggested by Greg (no code changes).
>
> Changes in v3:
> - Merged the previous 2-patch series into a single patch as suggested
> by Nikolay. Completely removed the redundant helper instead of
> renaming it with '__' prefixes.
>
> Changes in v2:
> - Resent the series due to submission issues with v1 (no code changes).
>
> Signed-off-by: Arsenii Pashchenko <ulijg308@xxxxxxxxx>

The changelog goes below the only --- line, and the signed-off-by goes
above it.

Try using the b4 tool for all of this, it should handle it for you
automatically.

thanks,

greg k-h