Re: [PATCH] staging: rtl8723bs: fix space before tab in HalPhyRf_8723B.c

[Greg KH]

On Mon, Jul 13, 2026 at 09:50:20PM +0530, Yash Pratap Kulshrestha wrote:
> Remove stray spaces before tabs throughout HalPhyRf_8723B.c,
> fixing checkpatch.pl warnings. Most of them were comments but
> some of them were variable declarations with unusual indents
> having mixed space/tab alignments.
> 
> Signed-off-by: Yash Pratap Kulshrestha <pratapyashkulshrestha@xxxxxxxxx>
> ---
>  .../staging/rtl8723bs/hal/HalPhyRf_8723B.c    | 116 +++++++++---------
>  1 file changed, 58 insertions(+), 58 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
> index 70b68f473d58..ebebc202971c 100644
> --- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
> +++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
> @@ -354,14 +354,14 @@ static u8 phy_PathA_IQK_8723B(
>  	/* leave IQK mode */
>  	PHY_SetBBReg(pDM_Odm->Adapter, rFPGA0_IQK, bMaskH3Bytes, 0x000000);
>  
> -	/* 	enable path A PA in TXIQK mode */
> +	/* enable path A PA in TXIQK mode */
>  	PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, RF_WE_LUT, 0x80000, 0x1);
>  	PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, RF_RCK_OS, bRFRegOffsetMask, 0x18000);
>  	PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, RF_TXPA_G1, bRFRegOffsetMask, 0x0003f);
>  	PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, RF_TXPA_G2, bRFRegOffsetMask, 0xc7f87);
> -	/* 	disable path B PA in TXIQK mode */
> -/* 	PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, 0xed, bRFRegOffsetMask, 0x00020); */
> -/* 	PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, 0x43, bRFRegOffsetMask, 0x40ec1); */
> +	/* disable path B PA in TXIQK mode */
> +/* PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, 0xed, bRFRegOffsetMask, 0x00020); */
> +/* PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, 0x43, bRFRegOffsetMask, 0x40ec1); */

That doesn't look correct anymore, right?

Why keep these lines at all?

thanks,

greg k-h