Re: [PATCH] staging: rtl8723bs: rename MACREG macros to snake_case
From: Greg Kroah-Hartman
Date: Fri Jul 17 2026 - 08:29:34 EST
On Sun, Jul 12, 2026 at 04:20:26PM +0300, Bohdan D. Marcus wrote:
> Fix checkpatch.pl warnings regarding CamelCase naming:
> CHECK: Avoid CamelCase: <_Read_MACREG>
> CHECK: Avoid CamelCase: <_Write_MACREG>
>
> Rename _Read_MACREG and _Write_MACREG to read_macreg and
> write_macreg respectively to comply with the Linux kernel
> coding style.
>
> Signed-off-by: Bohdan D. Marcus <bohdandmarcus@xxxxxxxxx>
> ---
> drivers/staging/rtl8723bs/core/rtw_cmd.c | 4 ++--
> drivers/staging/rtl8723bs/include/rtw_cmd.h | 4 ++--
> drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +-
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index b932670f5..f3b8a2bdf 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -11,8 +11,8 @@
> #include <linux/delay.h>
>
> static struct _cmd_callback rtw_cmd_callback[] = {
> - {GEN_CMD_CODE(_Read_MACREG), NULL}, /*0*/
> - {GEN_CMD_CODE(_Write_MACREG), NULL},
> + {GEN_CMD_CODE(read_macreg), NULL}, /*0*/
> + {GEN_CMD_CODE(write_macreg), NULL},
Why just these 2? Why not make a patch series to fix up all of these,
one patch per name?
thanks,
greg k-h