Re: [PATCH 2/3] regulator: pfuze100: add set_suspend_disable for LDO ops

[Mark Brown]

On Thu, Jul 16, 2026 at 11:50:54AM +0800, Joy Zou wrote:
> Add set_suspend_disable callback to pfuze100_ldo_regulator_ops to
> support regulator-off-in-suspend DTS property for VGEN regulators.
> This allows unused LDO regulators to be properly disabled during
> system suspend, reducing power consumption.

> +static int pfuze100_set_suspend_disable(struct regulator_dev *rdev)

This looks to be only used for LDOs but is named like it applies to all
regulators the driver supports.

> +{
> +	struct pfuze_chip *pfuze100 = rdev_get_drvdata(rdev);
> +	int id = rdev_get_id(rdev);
> +
> +	/*
> +	 * Set VGENxSTBY and clear VGENxLPWR so that the LDO output is
> +	 * disabled when the PMIC receives a STANDBY event.
> +	 * EN=1, LPWR=0, STBY=1 results in output Off when STANDBY is asserted.
> +	 */
> +	return regmap_update_bits(pfuze100->regmap,
> +				  pfuze100->regulator_descs[id].stby_reg,
> +				  PFUZE100_VGENxSTBY | PFUZE100_VGENxLPWR,
> +				  PFUZE100_VGENxSTBY);
> +}

This is a fixed bit in the register, but I see other regulators have
_stby_mask configuration.  Are you sure that all the LDOs in all the
regulators covered by this driver have this feature with this exact
control bit?

Attachment: signature.asc
Description: PGP signature