Re: [PATCH v6] hfsplus: fix null-ptr-deref by creating hidden dir on remount rw

[Deepanshu Kartikey]

On Wed, Jul 15, 2026 at 3:03 AM Viacheslav Dubeyko <slava@xxxxxxxxxxx> wrote:
>
                    hfsplus_sync_fs(sb, 1);
>
> I think that true is better than 1 for hfsplus_sync_fs() call.
>
> So, we didn't call hfsplus_prepare_volume_header_for_commit() and
> hfsplus_sync_fs() in hfsplus_reconfigure() before. But, probably, it's
> right thing to do. But currently, we call it only for the case of !sbi-
> >hidden_dir. Should we do it for every RW mount?
>
> Thanks,
> Slava.
>

hfsplus_sync_fs() takes int wait, not bool, so we cannot use true.
I will keep 1 as in the original code.

I will send patch v7 with required changes

Thanks