Re: [PATCH v9 2/4] clk: cix: add sky1 audss clock controller

[Brian Masney]

On Fri, Jul 17, 2026 at 09:47:28AM +0000, Joakim  Zhang wrote:
> > -----Original Message-----
> > > +static void sky1_audss_clk_remove(struct platform_device *pdev) {
> > > +     struct device *dev = &pdev->dev;
> > > +
> > > +     if (!pm_runtime_status_suspended(dev))
> > > +             pm_runtime_force_suspend(dev);
> > > +
> > > +     pm_runtime_disable(dev);
> > 
> > I am fairly certain that remove() is called before the devm handlers are
> > invoked. The clocks will be shutdown, but there's a window where they are still
> > visible to consumers. I think you should use
> > devm_add_action_or_reset() so that the cleanup is called in the expected order.
> Agreed. remove() runs before devres_release_all(), so force_suspend() tears down the hardware while the OF clock provider is still visible. I'll move the runtime PM cleanup into a devm_add_action_or_reset() registered before the clocks/provider, and drop it from remove().

I don't know which email client you are using but you should fix your
client so that the text in your response wraps at 80 characters. Also
add a newline between what you are quoting and your response since it
also makes things much nicer to read in the archive.

Brian