Re: [PATCH] scripts: headers_install.sh: Normalize __ASSEMBLY__ to __ASSEMBLER__

[Thomas Weißschuh]

On 2026-07-16 19:16:26+0100, Maciej W. Rozycki wrote:
> On Thu, 16 Jul 2026, Thomas Weißschuh wrote:
> 
> > > > However the UAPI headers might be used with older (< GCC 3.0) or
> > > > non-GCC-compatible compilers, which do not define __ASSEMBLY__
> > > > automatically.
> > > 
> > > I just had a try with gcc 2.95.4 from a Debian Woody installation, and it
> > > defines __ASSEMBLER__ automatically when compiling *.S files, i.e. gcc 2.95
> > > does not seem to be a problem. So can you point me to a real case where
> > > someone tried to use a user space compiler where __ASSEMBLER__ was not
> > > defined automatically? Otherwise, I think this patch could be reverted
> > > again.
> > 
> > I don't have a specific case I can point you to. My goal was
> > consistency. Therefore I am against reverting the patch as long as
> > both __ASSEMBLER__ and __ASSEMBLY__ are used in the UAPI headers.
> > If we want to switch to __ASSEMBLER__ for the UAPI headers today,
> > we should instead invert the logic of this patch to consistently use it
> > everywhere. After all UAPI headers are migrated, the normalization can
> > then be removed.
> 
>  I believe Thomas specifically refers to the mention of the alleged 
> shortcoming of pre-3.0 GCC, which we've since verified not to be true, as 
> quoted elsewhere in this thread, so the note needs to be dropped in a 
> respin.

It *was* dropped in a respin[0], which is the patch that got applied.

[0] https://lore.kernel.org/lkml/20260630-uapi-assembly-v2-1-8e7bee2fe816@xxxxxxxxxxxxxx/