Re: [PATCH v4] usb: typec: tcpm: implement retry mechanism for Discover Identity VDMs

[RD Babiera]

On Tue, Jul 14, 2026 at 3:02 AM Heikki Krogerus
<heikki.krogerus@xxxxxxxxxxxxxxx> wrote:
> This looks good to me but let's wait for Badhri. If you do v5, there
> is one nitpick below. Otherwise:
>
> I think you could trim the above a little with this (is 0 a valid
> version?):
>
>         if (svdm_version >= 0)
>                 tcpm_queue_vdm(port, msg[0], &msg[1], 0, tx_sop_type);
>
> >  unlock:
> >       mutex_unlock(&port->lock);
> >  }

0 is a valid version, it equates to SVDM_VER_1_0.
I'll add the nit to v5, thanks for taking a look!

Best,
RD