Re: [PATCH v3 2/4] ASoC: SDCA: Populate IRQ data earlier

[Pierre-Louis Bossart]

On 7/16/26 16:26, Charles Keepax wrote:
> Currently, the IRQ data (attached Entity/Control/etc) is populated
> as the IRQ is requested. However, this can cause issues as
> occasionally the setup process wants to access specifics of
> an IRQ before the IRQ is actually enabled. To facilitate this
> cache all the IRQ data during sdca_irq_populate_early() and make
> sdca_irq_populate() simply request the outstanding IRQs. This
> also has the advantage that sdca_irq_populate() can now just
> iterate through the IRQ array which is much smaller/faster than
> going through every Entity in the Function for Controls.
> 
> Signed-off-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>
> ---

I may be splitting hair but shouldn't this patch be moved
earlier?patch1/3-4 seem to be completely tied with the introduction and
use of the fixup_controls() callback, I am not sure I see the link with
the IRQ stuff. Or conversely move this last if this makes more sense.

Also while I am at it, I wouldn't hurt to have an explanation of the
races conditions earlier, it's only in patch3 that the race condition is
described in details.