[PATCH v6 09/16] drm/msm/gem: Remove useless locking in GEM import

From: Rob Clark

Date: Fri Jul 17 2026 - 16:53:18 EST


The locking has changed a few times over the years, and this extra
locking was the mistake of evolution. Harmless but useless.

Signed-off-by: Rob Clark <robin.clark@xxxxxxxxxxxxxxxx>
---
drivers/gpu/drm/msm/msm_gem.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c
index efd3d3c9a449..1aa844ce4f2c 100644
--- a/drivers/gpu/drm/msm/msm_gem.c
+++ b/drivers/gpu/drm/msm/msm_gem.c
@@ -1301,23 +1301,18 @@ struct drm_gem_object *msm_gem_import(struct drm_device *dev,
npages = size / PAGE_SIZE;

msm_obj = to_msm_bo(obj);
- msm_gem_lock(obj);
msm_obj->sgt = sgt;
msm_obj->pages = kvmalloc_objs(struct page *, npages);
if (!msm_obj->pages) {
- msm_gem_unlock(obj);
ret = -ENOMEM;
goto fail;
}

ret = drm_prime_sg_to_page_array(sgt, msm_obj->pages, npages);
if (ret) {
- msm_gem_unlock(obj);
goto fail;
}

- msm_gem_unlock(obj);
-
drm_gem_lru_move_tail(&priv->lru.pinned, obj);

mutex_lock(&priv->obj_lock);
--
2.55.0