Re: [PATCH] drm/nouveau: Omit a redundant pm_runtime_mark_last_busy() call in nouveau_pmops_runtime_idle()

[lyude]

Reviewed-by: Lyude Paul <lyude@xxxxxxxxxx>

Will push to drm-misc-next in just a moment

On Wed, 2026-03-25 at 15:05 +0100, Markus Elfring wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Wed, 25 Mar 2026 14:55:01 +0100
> 
> The device's last busy timestamp was set in a wrapper function since
> the commit 08071e64cb642ae19ebd6ffeb13b4f3d130b5860 ("PM: runtime:
> Mark last busy stamp in pm_runtime_autosuspend()").
> Thus delete a pm_runtime_mark_last_busy() call before
> a pm_runtime_autosuspend() call.
> 
> The source code was transformed by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/nouveau/nouveau_drm.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c
> b/drivers/gpu/drm/nouveau/nouveau_drm.c
> index 5d8475e4895e..62ac9593230f 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_drm.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c
> @@ -1209,7 +1209,6 @@ nouveau_pmops_runtime_idle(struct device *dev)
>  		return -EBUSY;
>  	}
>  
> -	pm_runtime_mark_last_busy(dev);
>  	pm_runtime_autosuspend(dev);
>  	/* we don't want the main rpm_idle to call suspend - we want
> to autosuspend */
>  	return 1;