Re: [PATCH] pid: fix cad_pid use-after-free race in proc_do_cad_pid()

[Mateusz Guzik]

On Fri, Jul 17, 2026 at 11:01 PM Cen Zhang (Microsoft)
<blbllhy@xxxxxxxxx> wrote:
>
> proc_do_cad_pid() reads the global cad_pid pointer and passes it to
> pid_vnr() without protecting the lifetime of the referenced struct pid.
> A concurrent writer can replace cad_pid and drop the final reference to
> the old struct pid after the reader has loaded the pointer but before
> pid_vnr() has finished dereferencing it, causing a use-after-free.
>
> Fix this by wrapping the read side in an RCU read-side critical section
> and waiting for a grace period before dropping the old cad_pid reference
> on the write side. Do not use call_rcu(&old_pid->rcu, ...) here:
> struct pid::rcu is already used by free_pid(), so queueing it again can
> corrupt the RCU callback list.
>
> KASAN crash stack:
>   kernel/pid.c:545 pid_nr_ns()          # reads freed pid->level
>   kernel/pid.c:556 pid_vnr()
>   kernel/pid.c:775 proc_do_cad_pid()
>   fs/proc/proc_sysctl.c proc_sys_call_handler()
>   fs/read_write.c vfs_read()
>   fs/read_write.c __x64_sys_pread64()
>
> Fixes: 9ec52099e4b8 ("[PATCH] replace cad_pid by a struct pid")
> Reported-by: AutonomousCodeSecurity@xxxxxxxxxxxxx
> Signed-off-by: Cen Zhang (Microsoft) <blbllhy@xxxxxxxxx>
> ---
>  kernel/pid.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/pid.c b/kernel/pid.c
> index f55189a3d07d..fee62b2c0c7b 100644
> --- a/kernel/pid.c
> +++ b/kernel/pid.c
> @@ -768,11 +768,15 @@ static int proc_do_cad_pid(const struct ctl_table *table, int write, void *buffe
>                 size_t *lenp, loff_t *ppos)
>  {
>         struct pid *new_pid;
> +       struct pid *old_pid;
>         pid_t tmp_pid;
>         int r;
>         struct ctl_table tmp_table = *table;
>
> +       rcu_read_lock();
>         tmp_pid = pid_vnr(cad_pid);
> +       rcu_read_unlock();
> +
>         tmp_table.data = &tmp_pid;
>
>         r = proc_dointvec(&tmp_table, write, buffer, lenp, ppos);
> @@ -783,7 +787,9 @@ static int proc_do_cad_pid(const struct ctl_table *table, int write, void *buffe
>         if (!new_pid)
>                 return -ESRCH;
>
> -       put_pid(xchg(&cad_pid, new_pid));
> +       old_pid = xchg(&cad_pid, new_pid);
> +       synchronize_rcu();
> +       put_pid(old_pid);
>         return 0;
>  }
>

I don't understand what this call to synchronize_rcu() is accomplishing.

sashiko points out the actual use of cad_pid in kill_cad_pid() suffers
the same liveness issue, i.e., the routine needs to enter rcu and grab
a ref on the found obj before issuing kill_pid(). I would deinline it
while patching the problem.