Re: [PATCH 04/13] iio: common: Remove redundant dev_err()

[Jonathan Cameron]

On Fri, 17 Jul 2026 17:42:27 +0800
Pan Chuang <panchuang@xxxxxxxx> wrote:

Hi,

Where there is only one driver affected, please name that driver
in the commit message.  Let's anyone who cares about other drivers
in that directory know they can ignore it!

Thanks,

Jonathan


> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
> 
> Signed-off-by: Pan Chuang <panchuang@xxxxxxxx>
> ---
>  drivers/iio/common/st_sensors/st_sensors_trigger.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/common/st_sensors/st_sensors_trigger.c b/drivers/iio/common/st_sensors/st_sensors_trigger.c
> index 8a8ab688d798..7b3e9732cc3e 100644
> --- a/drivers/iio/common/st_sensors/st_sensors_trigger.c
> +++ b/drivers/iio/common/st_sensors/st_sensors_trigger.c
> @@ -211,10 +211,8 @@ int st_sensors_allocate_trigger(struct iio_dev *indio_dev,
>  					irq_trig,
>  					sdata->trig->name,
>  					sdata->trig);
> -	if (err) {
> -		dev_err(parent, "failed to request trigger IRQ.\n");
> +	if (err)
>  		return err;
> -	}
>  
>  	err = devm_iio_trigger_register(parent, sdata->trig);
>  	if (err < 0) {