[PATCH v5] staging: rtl8723bs: remove redundant ReadChipVersion8723B wrapper
From: Arsenii Pashchenko
Date: Sat Jul 18 2026 - 00:15:09 EST
Collapse the static CamelCase helper function ReadChipVersion8723B()
directly into the main rtl8723b_read_chip_version() function.
This removes unnecessary code nesting and cleans up the CamelCase
naming violation in a single atomic change.
Signed-off-by: Arsenii Pashchenko <ulijg308@xxxxxxxxx>
---
Changes in v5:
- Edit patch as text, because b4 drop my diffs (no code changes).
Changes in v4:
- Format patch via b4 as suggested by Greg (no code changes).
Changes in v3:
- Merged the previous 2-patch series into a single patch as suggested
by Nikolay. Completely removed the redundant helper instead of
renaming it with '__' prefixes.
Changes in v2:
- Resent the series due to submission issues with v1 (no code changes).
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
index 1b8ae3d57..53f6cd708 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
@@ -820,7 +820,7 @@ void Hal_ReadEFuse(
hal_ReadEFuse_BT(padapter, _offset, _size_byte, pbuf);
}
-static void ReadChipVersion8723B(struct adapter *padapter)
+void rtl8723b_read_chip_version(struct adapter *padapter)
{
u32 value32;
struct hal_com_data *pHalData;
@@ -843,11 +843,6 @@ static void ReadChipVersion8723B(struct adapter *padapter)
pHalData->PolarityCtl = ((value32 & WL_HWPDN_SL) ? RT_POLARITY_HIGH_ACT : RT_POLARITY_LOW_ACT);
}
-void rtl8723b_read_chip_version(struct adapter *padapter)
-{
- ReadChipVersion8723B(padapter);
-}
-
void rtl8723b_InitBeaconParameters(struct adapter *padapter)
{
struct hal_com_data *pHalData = GET_HAL_DATA(padapter);
--
2.55.0