Re: [PATCH 03/13] iio: chemical: Remove redundant dev_err()/dev_err_probe()

From: Andy Shevchenko

Date: Sat Jul 18 2026 - 02:29:03 EST


On Fri, Jul 17, 2026 at 05:05:22PM -0500, Maxwell Doose wrote:
> On Fri Jul 17, 2026 at 4:42 AM CDT
> Pan Chuang <panchuang@xxxxxxxx> wrote:

...

> > @@ -686,7 +686,7 @@ static int scd30_setup_trigger(struct iio_dev *indio_dev)
> > IRQF_NO_AUTOEN,
> > indio_dev->name, indio_dev);
> > if (ret)
> > - return dev_err_probe(dev, ret, "failed to request irq\n");
> > + return ret;
> >
> > return 0;
> > }
>
> Please split per driver and resubmit and feel free to add
>
> Reviewed-by: Maxwell Doose <maxwell@xxxxxxxxxxx>
>
> once you do that.

This is trivial enough, so this sub-treewide approach is okay. When you want to
give a tag for certain piece of such a change, use comment style

Reviewed-... # for sdc30


--
With Best Regards,
Andy Shevchenko