Re: [PATCH v3 1/2] mm: vmscan: convert folio_referenced() to use vma_flags_t

[Barry Song]

On Fri, Jul 17, 2026 at 6:06 PM Baolin Wang
<baolin.wang@xxxxxxxxxxxxxxxxx> wrote:
>
> Replace use of the legacy vm_flags_t flags with vma_flags_t values for
> folio_referenced() and related logic. This is also a preparation for the
> following changes.
>
> No functional changes.
>
> Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>
> Acked-by: David Hildenbrand (Arm) <david@xxxxxxxxxx>

LGTM,
Reviewed-by: Barry Song <baohua@xxxxxxxxxx>

[...]
> @@ -1015,8 +1015,11 @@ static bool folio_referenced_one(struct folio *folio,
>                 referenced++;
>
>         if (referenced) {
> +               vma_flags_t vma_flags = vma->flags;
> +
>                 pra->referenced++;
> -               pra->vm_flags |= vma->vm_flags & ~VM_LOCKED;
> +               vma_flags_clear(&vma_flags, VMA_LOCKED_BIT);
> +               vma_flags_set_mask(&pra->vma_flags, vma_flags);

I spent a couple of minutes tracing how vma->vm_flags ends
up in pra, and it seems to be correct :-)

Best Regards
Barry