Re: [PATCH] USB: phy: fsl-usb: fix missing static keywords

[Manuel Ebner]

On Fri, 2026-07-17 at 17:49 +0200, Johan Hovold wrote:
> A recent change enabling compile testing of a Freescale dual-role
> controller indirectly enabled a USB PHY driver to be built. That driver
> in turn is missing a bunch of static keywords which results in warnings
> like:
> 
> drivers/usb/phy/phy-fsl-usb.c:105:5: error: no previous prototype for 'write_ulpi' [-
> Werror=missing-prototypes]
>   105 | int write_ulpi(u8 addr, u8 data)
>         |     ^~~~~~~~~~
> 
> which consequently breaks -Werror builds.
> 
> Add the missing static keywords.
> 
> Fixes: 0807c500a1a6 ("USB: add Freescale USB OTG Transceiver driver")
> Cc: stable@xxxxxxxxxxxxxxx	# 3.0

Add linux-next@xxxxxxxxxxxxxxx

> Reported-by: Mark Brown <broonie@xxxxxxxxxx>
> Link: https://lore.kernel.org/r/4f9f5ff9-8eaa-4bd5-9331-37119f78e13f@xxxxxxxxxxxxx
> Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>

Reviewed-by: Manuel Ebner <manuelebner@xxxxxxxxxxx>

Thanks
 Manuel

> ---
>  drivers/usb/phy/phy-fsl-usb.c | 52 +++++++++++++++++------------------
>  drivers/usb/phy/phy-fsl-usb.h |  6 ++--
>  2 files changed, 29 insertions(+), 29 deletions(-)
> 
> [...]