Re: [PATCH] irq/msi: fix misplaced EXPORT_SYMBOL_GPL for msi_domain_free_irqs_all
From: Radu Rendec
Date: Sat Jul 18 2026 - 07:56:03 EST
On Fri, 2026-07-17 at 22:31 +0800, lirongqing wrote:
> From: Li RongQing <lirongqing@xxxxxxxxx>
>
> The EXPORT_SYMBOL_GPL(msi_domain_free_irqs_all) was mistakenly placed
> after msi_domain_free_irqs_range() instead of after its intended
> function msi_domain_free_irqs_all().
>
> Signed-off-by: Li RongQing <lirongqing@xxxxxxxxx>
> ---
> kernel/irq/msi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/irq/msi.c b/kernel/irq/msi.c
> index 903be72..fb5f372 100644
> --- a/kernel/irq/msi.c
> +++ b/kernel/irq/msi.c
> @@ -1683,7 +1683,6 @@ void msi_domain_free_irqs_range(struct device *dev, unsigned int domid,
> guard(msi_descs_lock)(dev);
> msi_domain_free_irqs_range_locked(dev, domid, first, last);
> }
> -EXPORT_SYMBOL_GPL(msi_domain_free_irqs_all);
>
> /**
> * msi_domain_free_irqs_all_locked - Free all interrupts from a MSI interrupt domain
> @@ -1714,6 +1713,7 @@ void msi_domain_free_irqs_all(struct device *dev, unsigned int domid)
> guard(msi_descs_lock)(dev);
> msi_domain_free_irqs_all_locked(dev, domid);
> }
> +EXPORT_SYMBOL_GPL(msi_domain_free_irqs_all);
>
> /**
> * msi_device_domain_free_wired - Free a wired interrupt in @domain
Reviewed-by: Radu Rendec <radu@xxxxxxxxxx>