[PATCH v6 00/16] clk: qcom: Add DISPCC and GPUCC support for the Qualcomm Shikra SoC
From: Imran Shaik
Date: Sat Jul 18 2026 - 08:56:37 EST
This series adds support for the Display clock controller (DISPCC) and
GPU Clock Controller (GPUCC) on Qualcomm Shikra SoC, by reusing the
respective QCM2290 SoC drivers, and adds fix-ups for the QCM2290 Clock
drivers.
Signed-off-by: Imran Shaik <imran.shaik@xxxxxxxxxxxxxxxx>
---
Changes in v6:
- Rebased on next-20260716, as the dependent RPMCC/GCC and Shikra base DTS
changes were merged.
- Collected all Reviewed-by tags received on v5.
- Added the Fixes tags to relevant patches [Dmitry/Konrad]
- Reordered the series to place the fix patches at top of the series [Dmitry]
- Updated the DISPCC driver to use use_rpm, as required by the
power-domain fix-up changes [Konrad]
- Dropped the additional external clock, index-based driver, and DTS
changes to avoid an ABI change that has no functional impact [Krzysztof/Konrad]
- Updated the commit text for few patches [Konard/Dmitry]
- Link to v5: https://lore.kernel.org/r/20260703-shikra-dispcc-gpucc-v5-0-cc13826d4d5a@xxxxxxxxxxxxxxxx
Changes in v5:
- Collected all Reviewed-by tags received on v4.
- Updated the commit text of the bindings patches [Krzysztof]
- Converted only the critical GCC clocks to the latest clk_cbcr convention
- Reorganize the series into logically independent patches [Krzysztof/Dmitry]
- Added CX power domain support for DISPCC [Konrad]
- Dropped DSI1 PHY clock input support from the driver, as these clocks
are not referenced by any frequency table.
- Dropped moving dispcc driver to DT index approach patch as the
external sleep_clk is not there in the DTS, and no functional impact.
- Dropped HW_CTRL_TRIGGER patch as it is not applicable [Konrad]
- Link to v4: https://lore.kernel.org/r/20260604-shikra-dispcc-gpucc-v4-0-8204f1029311@xxxxxxxxxxxxxxxx
Changes in v4:
- Included new patch for Shikra DISPCC/GPUCC DT node support
- Link to v3: https://lore.kernel.org/r/20260601-shikra-dispcc-gpucc-v3-0-61c1ba3735e8@xxxxxxxxxxxxxxxx
Changes in v3:
- Updated the QCM2290 GCC patch to use the .clk_cbcr convention
- Extended the QCM2290 GPUCC bindings to add DSI1 PHY and Sleep clocks
- Separated the patches as per the review comments in v2 series
- Added Agatti DISPCC DT node changes as per the latest bindings changes
- Link to v2: https://lore.kernel.org/r/20260528-shikra-dispcc-gpucc-v2-0-953f246a0fbb@xxxxxxxxxxxxxxxx
Changes in v2:
- Dropped QCM2290 GCC critical clocks modelling to kept them ON from probe.
- Updated the QCM2290 DISPCC/GPUCC bindings to align for Shikra drivers reuse.
- Reused the QCM2290 DISPCC driver for Shikra without modernizing
(keeping the clock-names approach) for now to avoid potential bindings ABI breakage.
- Modernized QCM2290 GPUCC driver to use common qcom_cc_probe() model
and reuse for Shikra.
- Link to v1: https://lore.kernel.org/r/20260513-shikra-dispcc-gpucc-v1-0-5fd673146ab2@xxxxxxxxxxxxxxxx
---
Imran Shaik (16):
dt-bindings: clock: qcom,qcm2290-dispcc: Add missing power-domains property
clk: qcom: gcc-qcm2290: Keep the critical clocks always-on from probe
clk: qcom: dispcc-qcm2290: Move to the latest common qcom_cc_probe() model
clk: qcom: dispcc-qcm2290: Enable runtime PM support
clk: qcom: qcm2290: Set POLL_CFG_GDSCR flag for DISPCC and GPUCC GDSCs
clk: qcom: qcm2290: Add RETAIN_FF_ENABLE flag for DISPCC and GPUCC GDSCs
clk: qcom: qcm2290: Update DISPCC and GPUCC GDSC *wait_val values
clk: qcom: gpucc-qcm2290: Drop pm_clk handling
clk: qcom: gpucc-qcm2290: Move to the latest common qcom_cc_probe() model
clk: qcom: gpucc-qcm2290: Keep the critical clocks always-on from probe
clk: qcom: gpucc-qcm2290: Park RCG's clk source at XO during disable
arm64: dts: qcom: agatti: Add missing CX power domain to DISPCC
dt-bindings: clock: qcom: Add Qualcomm Shikra Display clock controller
dt-bindings: clock: qcom: Add Qualcomm Shikra GPU clock controller
clk: qcom: Add support for Qualcomm GPU Clock Controller on Shikra
arm64: dts: qcom: shikra: Add support for DISPCC/GPUCC nodes
.../bindings/clock/qcom,qcm2290-dispcc.yaml | 15 ++-
.../bindings/clock/qcom,qcm2290-gpucc.yaml | 4 +-
arch/arm64/boot/dts/qcom/agatti.dtsi | 1 +
arch/arm64/boot/dts/qcom/shikra.dtsi | 36 +++++++
drivers/clk/qcom/dispcc-qcm2290.c | 44 ++++----
drivers/clk/qcom/gcc-qcm2290.c | 113 +++------------------
drivers/clk/qcom/gpucc-qcm2290.c | 102 ++++++++-----------
7 files changed, 137 insertions(+), 178 deletions(-)
---
base-commit: 1a1757b76427f6201bfe0bf1bea9f7574f332a93
change-id: 20260513-shikra-dispcc-gpucc-6f59c23020f5
Best regards,
--
Imran Shaik <imran.shaik@xxxxxxxxxxxxxxxx>