Re: [PATCH v2 3/4] mm: vmscan: drop unused gfp_mask parameter from __node_reclaim()

From: Barry Song

Date: Sat Jul 18 2026 - 09:12:48 EST


On Sat, Jul 18, 2026 at 5:54 PM Ridong Chen <ridong.chen@xxxxxxxxx> wrote:
>
> From: Ridong Chen <chenridong@xxxxxxxxxx>
>
> Commit 57972c78e678 ("mm/vmscan: make __node_reclaim() more generic")
> moved the scan_control construction out to the callers and passed the
> struct in by pointer. After that change every use of the gfp mask inside
> __node_reclaim() goes through sc->gfp_mask, leaving the gfp_mask parameter
> unused. Just remove the dead parameter and update the callers accordingly.
> No functional change.
>
> Acked-by: Shakeel Butt <shakeel.butt@xxxxxxxxx>
> Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>
> Reviewed-by: Muchun Song <muchun.song@xxxxxxxxx>
> Signed-off-by: Ridong Chen <chenridong@xxxxxxxxxx>

Reviewed-by: Barry Song <baohua@xxxxxxxxxx>