Re: [PATCH v2] staging: greybus: audio: split topology get into size and data calls

[Aditya Chari S]

Hi Greg,
Thanks for the heads up — I'll rebase against your current staging
tree and resend as v3.

Regards,
Aditya

On Tue, Jul 7, 2026 at 2:50 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Wed, Jul 01, 2026 at 02:19:08AM +0530, adi25charis@xxxxxxxxx wrote:
> > From: Aditya Chari S <adi25charis@xxxxxxxxx>
> >
> > gb_audio_gb_get_topology() combined three separate responsibilities
> > into a single call: querying the topology size, allocating a buffer
> > for it, and fetching the topology data into that buffer. This left
> > callers with no way to perform any of these steps independently, and
> > forced the kzalloc() allocation to live inside the protocol-layer
> > driver rather than the caller, as already flagged by a FIXME comment
> > at the call site in audio_module.c.
> >
> > Split the function into two:
> >
> >   gb_audio_gb_get_topology_size() - queries only the topology size
> >   gb_audio_gb_get_topology()      - fetches topology data into a
> >                                      caller-supplied buffer of a
> >                                      given size
> >
> > Update the only caller, gb_audio_probe() in audio_module.c, to query
> > the size first, allocate the topology buffer itself, then fetch the
> > data into it, freeing the buffer via the existing free_topology error
> > path on failure.
> >
> > This resolves both the "TODO: Split into separate calls" comment
> > above the original function in audio_gb.c and the FIXME comment at
> > the call site in audio_module.c, both of which are removed as part
> > of this change.
> >
> > No functional change in behavior for the existing probe path.
> >
> > Compile-tested with W=1, sparse (C=2), and checkpatch.pl; all clean
> > on the three changed files (audio_gb.c, audio_module.c, audio_codec.h).
> >
> > Signed-off-by: Aditya Chari S <adi25charis@xxxxxxxxx>
>
> Does not apply to my tree :(