Re: [PATCH v2 2/2] arm64: dts: rockchip: Add Vicharak Vaaman board

[Andrew Lunn]

> +&gmac {
> +	assigned-clocks = <&cru SCLK_RMII_SRC>;
> +	assigned-clock-parents = <&clkin_gmac>;
> +	clock_in_out = "input";
> +	phy-supply = <&vcc3v3_lan>;
> +	/* TX/RX delays tuned for the Vaaman board PCB trace lengths */
> +	phy-mode = "rgmii";

Please could you read:

https://elixir.bootlin.com/linux/v6.15/source/Documentation/devicetree/bindings/net/ethernet-controller.yaml#L287

and then expand the comment to explain in detail what is going on
here.

> +	pinctrl-names = "default";
> +	pinctrl-0 = <&rgmii_pins>;
> +	snps,reset-gpio = <&gpio3 RK_PB7 GPIO_ACTIVE_LOW>;
> +	snps,reset-active-low;
> +	snps,reset-delays-us = <0 10000 50000>;
> +	tx_delay = <0x28>;
> +	rx_delay = <0x11>;
> +	status = "okay";
> +};

I don't see a phy-handle here?

  Andrew