Re: [PATCH v10 1/2] dt-bindings: iio: health: add adi,max86150

[Jonathan Cameron]

On Fri, 17 Jul 2026 23:11:36 +0300
Md Shofiqul Islam <shofiqtest@xxxxxxxxx> wrote:

> Add the Device Tree binding schema for the Analog Devices MAX86150
> integrated biosensor, which combines two photoplethysmography (PPG)
> channels (Red LED and IR LED) and one electrocardiogram (ECG) channel
> in a single I2C device. Samples are buffered in a 32-entry hardware
> FIFO with a configurable almost-full interrupt.
> 
> The device requires four independent supply rails per the datasheet
> power tree: digital core (vdd), analog core (avdd), ECG reference
> (vref), and LED anode (leds).
> 
> Assisted-by: Claude:claude-sonnet-5
> Signed-off-by: Md Shofiqul Islam <shofiqtest@xxxxxxxxx>
A few small things inline from a fresh look.

Thanks,

Jonathan

> ---
>  .../bindings/iio/health/adi,max86150.yaml     | 78 +++++++++++++++++++
>  MAINTAINERS                                   |  6 ++
>  2 files changed, 84 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/health/adi,max86150.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/health/adi,max86150.yaml b/Documentation/devicetree/bindings/iio/health/adi,max86150.yaml
> new file mode 100644
> index 0000000000000..da2ff9b0ada2b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/health/adi,max86150.yaml
> @@ -0,0 +1,78 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/health/adi,max86150.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices MAX86150 ECG and PPG Biosensor
> +
> +maintainers:
> +  - Md Shofiqul Islam <shofiqtest@xxxxxxxxx>
> +
> +description: |
> +  The MAX86150 is an integrated biosensor SoC that combines:
> +    - Two PPG (photoplethysmography) channels: Red LED and IR LED,
> +      for heart rate and blood-oxygen saturation (SpO2) measurement.
> +    - One ECG (electrocardiogram) channel for biopotential recording.
> +
> +  The device communicates over I2C at up to 400 kHz and raises an
> +  active-low interrupt when the 32-entry hardware FIFO reaches its
> +  configurable almost-full threshold.

For this the 32-entry fifo bit is good but maybe move ti to the interrupt
description. The rest of this paragraph is a repeat of detail below where
it is more useful. Hence I would drop it.

> +
> +  Datasheet:
> +    https://www.analog.com/media/en/technical-documentation/data-sheets/MAX86150.pdf
> +
> +properties:
> +  compatible:
> +    const: adi,max86150
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +    description: |

Formatting not needed so drop the |

> +      Active-low interrupt line.  Asserted when the FIFO almost-full
> +      threshold is reached or when a new PPG sample is ready.