Re: [PATCH net-next v2 2/2] net: stmmac: dwmac-rk: enable the reference clock for output mode
From: Jiaxing Hu
Date: Sat Jul 18 2026 - 23:47:00 EST
> You've taken my review into account (thanks :) ), but you're failing to
> address Andrew's comment.
>
> The PHY should be the one requesting the MAC to output the refclk, in
> that case the MAC will act as a clock provider [...]
You are both right, and I am sorry I missed Andrew's point on v1. The MAC
should not own the PHY's clock.
I have dropped this series. Instead the motorcomm driver now enables the
reference clock itself, which is the consumer that needs it:
https://lore.kernel.org/all/20260719034555.3623003-1-gahing@xxxxxxxxxxxxx/
The device tree names the YT8531 explicitly so the PHY is instantiated
without an MDIO ID probe, which it cannot answer before that clock runs;
the DTS goes to the rockchip tree. Tested on an ArmSoM CM5-IO: the PHY
links at 1000 Mbit/s with no dwmac-rk change at all.
Thanks for the review,
Jiaxing