RE: [PATCH 3/3] mei: Remove redundant dev_err()
From: Usyskin, Alexander
Date: Sun Jul 19 2026 - 01:45:13 EST
> Subject: [PATCH 3/3] mei: Remove redundant dev_err()
>
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
Acked-by: Alexander Usyskin <alexander.usyskin@xxxxxxxxx>
> Signed-off-by: Pan Chuang <panchuang@xxxxxxxx>
> ---
> drivers/misc/mei/gsc-me.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/misc/mei/gsc-me.c b/drivers/misc/mei/gsc-me.c
> index 73d5beeb9c34..376840b2c354 100644
> --- a/drivers/misc/mei/gsc-me.c
> +++ b/drivers/misc/mei/gsc-me.c
> @@ -101,10 +101,8 @@ static int mei_gsc_probe(struct auxiliary_device
> *aux_dev,
> mei_me_irq_quick_handler,
> mei_me_irq_thread_handler,
> IRQF_ONESHOT,
> KBUILD_MODNAME, dev);
> - if (ret) {
> - dev_err(device, "irq register failed %d\n", ret);
> + if (ret)
> goto err;
> - }
> }
>
> ret = mei_register(dev, device);
> --
> 2.34.1