Re: [PATCH 1/4] regulator: dt-bindings: Add Silergy SYR82X allowed modes

[Krzysztof Kozlowski]

On 17/07/2026 16:14, Victor Krawiec wrote:
> 
> 
> On 7/17/26 14:44, Mark Brown wrote:
>> On Fri, Jul 17, 2026 at 02:31:51PM +0200, Krzysztof Kozlowski wrote:
>>
>>> So you are adding constants for one device but used in the bindings and
>>> driver for other? Are they valid there?
>>
>> It's one of these devices that's got a bunch of clones from various
>> manufacturers with minor differences and share a driver.
> 
> I checked the datasheets and all devices share the same 2 modes which
> are Auto-PFM and Forced PWM mode.
> 
> Since devices are all clones and share the same modes the binding part
> can be generic. I plan to rename the header and its macros to use
> FAN53555 name and add this property to the binding:
> 
> regulator-initial-mode:
>     enum:
>       [ 1, 2 ]
>     description:
>       Defined in
>       include/dt-bindings/regulator/fcs,fan53555-regulator.h
> 
> However the implementation I made in the driver is currently
> restricted to SYR82X. I could make it generic but I don't have access
> to the other devices to test it.
> 

Old name of header file is fine, but please explain this in commit msg.

Best regards,
Krzysztof