Re: [PATCH v4 1/2] dt-bindings: usb: Add ITE IT8851/IT8853 Type-C PD controllers

From: Krzysztof Kozlowski

Date: Sun Jul 19 2026 - 03:37:38 EST


On Fri, Jul 17, 2026 at 05:59:49PM +0800, Amber Kao wrote:
> +description:
> + The ITE IT8851 is an I2C-based USB Type-C Power Delivery (PD) controller
> + supporting one Type-C port.
> + The IT8853 is the two-port variant sharing the same programming interface.
> +
> +properties:
> + compatible:
> + enum:
> + - ite,it8851
> + - ite,it8853

According to your driver code, these are fully compatible, so why aren't
the compatibility expressed with the fallback?

> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + wakeup-source: true
> +
> + '#address-cells':
> + const: 1
> +
> + '#size-cells':
> + const: 0
> +
> +patternProperties:
> + "^connector@[01]$":

Keep consistent quotes, either ' or "

> + $ref: /schemas/connector/usb-connector.yaml#
> + unevaluatedProperties: false
> +
> +required:
> + - compatible
> + - reg
> + - interrupts

You also need:

anyOf:
- required:
- connector@0
- required:
- connector@1

Best regards,
Krzysztof