Re: [PATCH] pinctrl: microchip-sgpio: add missing select REGMAP_MMIO

[Andy Shevchenko]

On Sun, Jul 19, 2026 at 12:38 AM Benjamin Boortz <bennib@xxxxxxxxxxx> wrote:
>
> The driver calls ocelot_regmap_from_resource() via <linux/mfd/ocelot.h>,
> which internally uses devm_regmap_init_mmio() and requires REGMAP_MMIO.
> The Kconfig entry does not select REGMAP_MMIO, causing a build failure
> when no other driver in the config happens to pull in REGMAP_MMIO:

>   include/linux/mfd/ocelot.h:19:51: warning: 'struct regmap_config'
>     declared inside parameter list will not be visible outside of this
>     definition or declaration
>   include/linux/mfd/ocelot.h:34:24: error: implicit declaration of
>     function 'devm_regmap_init_mmio'
>   drivers/pinctrl/pinctrl-microchip-sgpio.c:910:16: error: variable
>     'regmap_config' has initializer but incomplete type
>   drivers/pinctrl/pinctrl-microchip-sgpio.c:911:18: error: 'struct
>     regmap_config' has no member named 'reg_bits'

Reduce this to one most significant line.

  include/linux/mfd/ocelot.h:34:24: error: implicit declaration of
function 'devm_regmap_init_mmio'

And make it a single line as it is in the real output.

> Found by randconfig testing on arm64; tinyconfig reproducer below.
>
> Fixes: 68c873363a78 ("pinctrl: microchip-sgpio: add ability to be used in a non-mmio configuration")

Wrong. Needs to be
2afbbab45c26 ("pinctrl: microchip-sgpio: update to support regmap")

...

With these being addressed, feel free to add
Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx>

-- 
With Best Regards,
Andy Shevchenko