Re: [PATCH v3 1/4] dt-bindings: media: snps,dw-hdmi-rx: add #sound-dai-cells

From: Krzysztof Kozlowski

Date: Sun Jul 19 2026 - 04:54:43 EST


On Sat, Jul 18, 2026 at 10:57:25AM +0200, Igor Paunovic wrote:

> diff --git a/Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.yaml b/Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.yaml
> index b7f6c87..fa6cd0d 100644
> --- a/Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.yaml
> +++ b/Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.yaml
> @@ -78,6 +78,13 @@ properties:
> The phandle of the syscon node for the Video Output GRF register
> to enable EDID transfer through SDAIN and SCLIN.
>
> + "#sound-dai-cells":
> + const: 1
> + description:
> + The HDMI RX controller has two digital audio interfaces, one for
> + I2S and one for S/PDIF. The DAI cell selects the interface, 0 for
> + I2S and 1 for S/PDIF.
> +

Schema should also reference dai-common.yaml and use
"unevaluatedProperties: false".

> required:
> - compatible
> - reg
> @@ -129,4 +136,6 @@ examples:
> pinctrl-0 = <&hdmim1_rx_cec &hdmim1_rx_hpdin &hdmim1_rx_scl &hdmim1_rx_sda &hdmirx_5v_detection>;
> pinctrl-names = "default";
> hpd-gpios = <&gpio1 22 GPIO_ACTIVE_LOW>;
> + /* referenced by a sound card as <&hdmi_receiver 0> (0: I2S, 1: S/PDIF) */

Drop comment, not needed. Consumer is not really relevant.

Best regards,
Krzysztof