Re: [PATCH v2] pinctrl: microchip-sgpio: add missing select REGMAP_MMIO

From: Andy Shevchenko

Date: Sun Jul 19 2026 - 05:49:39 EST


On Sun, Jul 19, 2026 at 11:41:46AM +0200, Benjamin Boortz wrote:
> The driver calls ocelot_regmap_from_resource() via <linux/mfd/ocelot.h>,
> which internally uses devm_regmap_init_mmio() and requires REGMAP_MMIO.
> The Kconfig entry does not select REGMAP_MMIO, causing a build failure
> when no other driver in the config happens to pull in REGMAP_MMIO:
>
> include/linux/mfd/ocelot.h:34:24: error: implicit declaration of function 'devm_regmap_init_mmio'
>
> Found by randconfig testing on arm64; tinyconfig reproducer below.
>
> Fixes: 2afbbab45c26 ("pinctrl: microchip-sgpio: update to support regmap")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Benjamin Boortz <bennib@xxxxxxxxxxx>
> Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx>
> ---

This is v2. It misses a changelog here.

No need to resend _this_ time, just reply to this query with
what has been changed v1..v2.

--
With Best Regards,
Andy Shevchenko