Re: [PATCH 0/4] drivers/misc: add Goodix GXFP5130 eSPI fingerprint sensor driver

[Metehan Günen]

On Sat, Jul 18, 2026 at 11:05:30AM +0200, Greg KH wrote:
> Is that the "normal" user/kernel api for these types of sensors?  I
> thought we had a real api these days, and a vendor one was not generally
> a good idea as you are just exposing raw hardware design to userspace.

The GXFP5130 communicates using a vendor-specific MP protocol over the
eSPI mailbox — it is not USB HID-compliant and does not expose a
standard fingerprint command set. The libfprint plugin that consumes
this device speaks the protocol directly and handles enrollment and
matching entirely in userspace, the same model used by other libfprint
char-device backends (e.g. goodix-55x4, elan-i2c).

I am open to alternative approaches. If there is a preferred kernel-side
abstraction for this class of device I should be targeting instead,
please point me to it and I will rework the driver accordingly.

The large file count (51 files) reflects the upstream tree layout of the
out-of-tree driver I ported. v2 will consolidate the driver into a
single .c file as is standard for misc drivers of this size.

The original driver code was written by Void755 (github.com/Void755),
who developed it for out-of-tree use. I ported it to mainline kernel
conventions with assistance from an AI tool for the reformatting work.
That AI assistance introduced several of the style issues you have
pointed out across the patches. I will fix all of them in v2 and add
proper copyright attribution for both Void755 and myself.

Thanks,
Metehan Günen